member.php modification for better plugins support.

[Wicko]

Hi, I'm glad i can post on this forum.
I use MyBB since 1.4.4. However, the forum is integrated with my game server in some way and I had to write a special plugin for it.

Unfortunately, I had to modify 2 files to get it done. For a better illustration of what i wanted to do, I'll just post a link to the registration page: http://h-rp.pl/member.php?action=register
As you can see, I'm forcing members to write answers for few questions. When they register, they get an "waiting for activation" group - but they're unable to activate it themselves. Only administration team can do it. We read the answers and if they won't pass the test, their accounts are getting automatically blocked.
There is however one way then can get registered without administrator's activation (by giving us some data from the time before we used MyBB) and then i want to set their group just to 5 - Registered.

But to do this, I couldn't find another way than modifying the member.php file. Plugins can't set the variable of group, due to this:

Code:

    if($mybb->settings['regtype'] == "verify" || $mybb->settings['regtype'] == "admin" || $mybb->input['coppa'] == 1)
    {
        $usergroup = 5;
    }
    else
    {
        $usergroup = 2;
    }

The only thing that has to be changed is adding a simple if statement:

Code:

    //hrp mod
    if(!isset($usergroup))
    {
        if($mybb->settings['regtype'] == "verify" || $mybb->settings['regtype'] == "admin" || $mybb->input['coppa'] == 1)
        {
            $usergroup = 5;
        }
        else
        {
            $usergroup = 2;
        }
    }

So in my plugin i can do:

Code:

            //set usergroup so he registers accepted
            $usergroup = 2;

Very, very simple modification, but gives us more freedom in what plugins can do during the registration process. I think so, at least.
Maybe I omitted some other way to do it - if so, please help me getting it done properly. Thanks!

[MattRogowski]

Isn't related to this but I have to say that you should really upgrade, you're 4 versions behind the current release, and you're open to a high security issue.

[Wicko]

No, I'm on 1.4.7 currently and I was preparing for upgrade to 1.4.8 - that made me post this thread
I just mentioned, that i was starting on 1.4.4 and i forgot to add the rest. I'm sorry.

[frostschutz]

Can't you do that in the datahandler_user_validate hook?

[MattRogowski]

(07-03-2009 02:10 PM)Wicko Wrote:  No, I'm on 1.4.7 currently and I was preparing for upgrade to 1.4.8

Ah, I missed the 'since' in your post, nevermind then