[F] Users ban is not lifted in class_session - bad banned cache array?

[koziolek]

MyBB 1.4.2

Ban for user is not lifted by class_session.php. Probably because of bad array in data cache.
class_session.php is using $UID as a key:

PHP Code:

        // Read the banned cache
        $bannedcache = $cache->read("banned");    
        ...
        ...
        if($bannedcache[$uid])
        { 


But in class_datacache.php we have:

PHP Code:

    function update_banned()
    {
        global $db;
        
        $bans = array();
        
        $query = $db->simple_select("banned");
        while($ban = $db->fetch_array($query))
        {
            $bans[] = $ban;
        }
    } 


And result - banned cache is not indexed by UIDs.

[Dennis Tsang]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

With regards,
MyBB Group