MyBB

Yumi · 08-26-2008, 07:14 AM

(08-25-2008 11:48 PM)Ryan Gordon Wrote: How will it put in a uid with a number higher then 0 if it doesn't even exist? Either way my "if statement" should catch all cases - It's not a strict comparison.

The uid does exist - unless when you delete a user, it sets the uids for all the user's attachments to 0.

**destroyer** · 08-26-2008, 11:56 AM

Any new fix that I have to test?

Ryan Gordon · (This post was last modified: 08-27-2008 12:03 AM by Ryan Gordon.)

(08-26-2008 07:14 AM)ZiNgA BuRgA Wrote:
(08-25-2008 11:48 PM)Ryan Gordon Wrote: How will it put in a uid with a number higher then 0 if it doesn't even exist? Either way my "if statement" should catch all cases - It's not a strict comparison.
The uid does exist - unless when you delete a user, it sets the uids for all the user's attachments to 0.

Yes, and? We're not doing a strict comparison. The NOT operator (!) will fail on 0, null, false, and probably others too that I don't remember.

Yumi · 08-27-2008, 05:47 AM

(08-27-2008 12:02 AM)Ryan Gordon Wrote:
(08-26-2008 07:14 AM)ZiNgA BuRgA Wrote:
(08-25-2008 11:48 PM)Ryan Gordon Wrote: How will it put in a uid with a number higher then 0 if it doesn't even exist? Either way my "if statement" should catch all cases - It's not a strict comparison.
The uid does exist - unless when you delete a user, it sets the uids for all the user's attachments to 0.

Yes, and? We're not doing a strict comparison. The NOT operator (!) will fail on 0, null, false, and probably others too that I don't remember.

I'll give an example to explain:

- User with UID 5 uploads an attachment
- attachments table will have something like this row:
aid: 2
uid: 5
etc
- You delete the user with UID of 5
- attachments table still has this row:
aid: 2
uid: 5
etc

Thus, uid=5 is still there. I haven't tested anything, but I'm guessing that in disambiguation, since you're putting users.uid and attachments.uid, the former being NULL, the latter will be returned, thus "uid" will be 5. My idea is to separate the disambiguation so that you're testing for the correct value. (MySQL strict mode does help in certain cases ya know...)