[F] [Mod CP] multiple multipage-related bugs

[WDZ]

File /modcp.php

Some evidence of lazy copying and pasting:

PHP Code:

$postcount = intval($report_count)+1; // line 129
$postcount = intval($warnings)+1;     // line 239
$postcount = intval($banned_count)+1; // line 2320 


The +1 came from showthread.php where it's added to a thread's reply count.

----------

In action=modqueue, the pagination doesn't seem to work at all because the wrong variable ($postcount) is passed to multipage().

(needs to be fixed in 3 places)

----------

Typo: $unapprovedthreads should be $unapproved_attachments

----------

In action=modlogs, there are two typos in the URL passed to multipage():

1. "orderby" should be "sortby"
2. $mybb->input['sortby'] should be enclosed in curly brackets or else Array['sortby'] appears in the URL.
   

[Sergio Montoya]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.