[F] upgrade problem (1.2.2=>1.4) "field_exists function"

[imei]

I believe that upgrade process has some mistaken usage of field_exists function:

PHP Code:

if($db->field_exists('oldadditionalgroups', TABLE_PREFIX."banned"))
    {
        $db->write_query("ALTER TABLE ".TABLE_PREFIX."banned DROP oldadditionalgroups;");
    }
    $db->write_query("ALTER TABLE ".TABLE_PREFIX."banned ADD oldadditionalgroups TEXT NOT NULL AFTER oldgroup"); 


upgrade8.php,ln34
table_perfix should be cleaned from first line

[LeX-]

TABLE_PREFIX is only removed in MyBB 1.4 queries ?
That's part of the upgrade process;
People who upgrade from 1.2.2 to 1.2.14 also need to use that file where TABLE_PREFIX is still needed in those queries.

[imei]

Please take a look at db->field_exists function in 1.4, It did use a TABLE_PREFIX inside of it, so another TABLE_PREFIX is completely wrong. Or am I wrong?

[Ryan Gordon]

Yeh, it seems your right imei. I have no idea why that wasn't changed :\

[Ryan Gordon]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.