[F] Little omission in inc/functions.php

[Troll]

Hi all,

I was watching through the 1.4 inc/functions.php file in order to make modification for this new version and I find something strange...

In the last release of 1.2 series, the 1.2.14, this line has been fixed :

Code:

if($uid != $mybb->user['uid'])

To this :

Code:

if($uid != 0 && $uid != $mybb->user['uid'])

(it's line 852)

But in the functions.php file of the 1.4 release, the line is this yet :

Code:

if($uid != $mybb->user['uid'])

I imagine the modification that was made on 1.2.14 file was forgotten and not included in the 1.4 file, so I report it.


Good evening (or good morning / afternoon anywhere you are).

[Ryan Gordon]

Both MyBB 1.2 and MyBB 1.4 have:

PHP Code:

if($uid != $mybb->user['uid']) 


Not sure where your code change came from.

[Troll]

Hello Tikitiki,

I've just verified : the inc/functions.php file included in the last revision of MyBB 1.2 (1.2.14), located in your post, contains at line 837 this code :

Code:

if($uid != 0 && $uid != $mybb->user['uid'])

So I am sure where my code change came from : you, in your last revision of Mybb 1.2(.14)

[Ryan Gordon]

Hi,

Okay thank you. I'm not sure why I missed that.

Ryan

[Ryan Gordon]

Thank you for your bug report.

This bug has been fixed in our internal code repository. Please note that the problem will not be fixed here until these forums are updated.

[Troll]

Hi,


Perfect This is not an important change anyway


Thank you for your work.


Regards,


Troll

[cHarOn]

only to understand what does it? and can we change that line per hand?